[solved] After approve review not able to merge pull request

vbose1 · March 25, 2019, 6:34am

Hi,

I am not able to merge pull request after pull request get reviewed.

and when set minimum approval in branch it display like this

not getting merge button.

Using version 1.7.4

lunny · March 26, 2019, 6:49am

Have you add your approval users in whitelist?

All users who added whitelist’s approvals will be count 1 but 0

vbose1 · March 26, 2019, 6:56am

Yes I apply the setting for required approval

lunny · March 26, 2019, 6:57am

Whitelisted reviewers or Whitelisted teams should be filled also.

vbose1 · March 26, 2019, 7:01am

Any of them from these teams or reviewers

vbose1 · March 26, 2019, 7:05am

After make change in setting got this message

and when I add the user in Whitelisted reviewers who approved the pull request it show this message

lunny · March 26, 2019, 7:08am

are these two approvers added to that whitelists?

vbose1 · March 26, 2019, 7:13am

the setting is as bellow

in this RBhardwaj has done the review

lunny · March 26, 2019, 7:15am

Ther merger should be filled on merge whitelist

lunny · March 26, 2019, 7:18am

If you disable merge whitelist, users who have write permission to this repositories could merge this PR.

vbose1 · March 26, 2019, 7:20am

Great, very valuable help from you. Really appreciated